Posts tagged "Bug Fix"
This isn't that important of a bug fix, and I bet most people won't notice either way. But it does need a bit of explanation to make sense, so here is a blog post!
Some people reported performance issues in my games recently. After debugging I found that there is indeed a serious performance bug in some situations. For example, viewing the standings page and auto playing a season took 3x as long as it did a couple weeks ago. That's pretty bad!
After looking in my past commits to identify exactly when the slowdown started, I found it happened when I upgraded @rollup/plugin-commonjs from version 21 to 22. That's a package used in compiling JS for production. Annoyingly, it's only used in production mode and not in dev mode, which makes it harder for me to notice a bug like this. But for this package to cause a slowdown is strange... it feels more like something that should either work fine or completely break, not cause a performance issue. So while I could stop here, switch back to the old version, and call it a day... let's go further.
Previously, some of you had noticed something strange about team construction and game simulation in Football GM. If you made a team of all one type of player, that team would actually perform pretty well, usually making the playoffs. Obviously that doesn't make any sense.
Looking at it more closely, I noticed that only passing stats were behaving strangely. A team of all kickers was horrible at running and at stopping the run. But they were incredible at passing! So I took a look at the passing code. Turns out the problem was just a small typo. The effects of pass blocking and pass rushing were reversed for calculating the completion percentage and distance of passes. My bad. Small fix.
But this is actually really important, and not just for silly things like a team of all kickers!
When I make a small improvement to Basketball GM, it feels silly to write a whole blog post about it. But if I don't, some people will never realize what happened. So maybe this is a good idea: a single blog post explaining several recent small improvements.